fix: let the back button leave a multi-page form from its first page - #158
Merged
Merged
Conversation
Seen in the ApptiveTeams app on the iOS simulator: the attachment source menu ("Take photo or video", "Photo library", "Select files") shows question-mark boxes instead of icons, and so does the new "Record video" button.
`add_attachment_button.dart` uses `CupertinoIcons` on Apple platforms, but `apptive_grid_form` never declared `cupertino_icons`, the package that ships the font. Apps that happen to depend on it themselves get icons; ApptiveTeams does not, so the glyphs are missing. Pre-existing since the menu was introduced; it just became more visible with the video button.
- `cupertino_icons: ^1.0.8` added as a dependency.
- Version 2.3.1, changelog entry.
No code change. Verified: analyzer, attachment widget tests, format gate, `pub publish --dry-run`.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
PRMSG
gh pr view --json number,url --jq '"#" + (.number|tostring) + " " + .url'
fix: bundle the Cupertino icon font used by the attachment menu
The attachment source menu and the "Record video" button use
CupertinoIcons on Apple platforms, but the package never depended on
cupertino_icons, which ships the font. Apps without their own dependency
on it – ApptiveTeams among them – rendered question marks instead.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…157) Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Resolves the 2.3.1 changelog conflict: keep both fix lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the back-button fix from #157 to
main. #157 was merged intofix/cupertino-icons-dependencyafter #156 had already been squash-merged, somainnever received it. The diff againstmainis exactly the #157 change plus its changelog line:PopScope.canPopof a multi-page form was computed from_pageController.hasClients && page == 0at the first build, when the controller has no clients yet. It stayedfalseforever, so the back button was dead on every page, including the first one.PageView.onPageChanged; back leaves the form from the first page and goes to the previous page otherwise.Completes the 2.3.1 changelog (
cupertino_iconsfix already onmain).🤖 Generated with Claude Code