A resume drops only the resumed strand's address - #134
Merged
Merged
Conversation
Two iterations of a parallel scope park the very same transition or node, each registered under its own token. Resuming one dropped every registry entry naming the suspension, so the other iteration's address was gone while its token still waited: its signal answered a silent false. One flow form per list entry, and the first submit spent the other links. FBBaseExecutor>>resume:withToken:value: now takes the token first and drops the entry of that token only (FBFlowInstance>> dropWaitingEntriesMatching:token:). A resume that ends up without a token - a suspension parked before tokens were kept - still drops every entry of the suspension, there being nothing to tell them apart by. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two iterations of a parallel scope park the very same transition or node, each registered under its own token. Resuming one dropped every registry entry naming the suspension, so the other iteration's address was gone while its token still waited: its signal answered a silent false. One flow form per list entry, and the first submit spent the other links.
FBBaseExecutor>>resume:withToken:value: now takes the token first and drops the entry of that token only (FBFlowInstance>> dropWaitingEntriesMatching:token:). A resume that ends up without a token - a suspension parked before tokens were kept - still drops every entry of the suspension, there being nothing to tell them apart by.