A parallel scope's step asks and records like the root executor's - #142
Merged
Merged
Conversation
FBParallelExecutor>>step now does the two things FBFlowExecutor>>step does around a transition: it asks the instance first (FBFlowInstance>>aboutToTransition:, where ApptiveBase counts its rate limits - a loop used to bypass them) and records an FBTransitionFollowed (a scope's log had no transitions at all). Both only for a transition actually followed, since inside a scope the branch condition is decided at the step; a refusal raised from the hook leaves the work item queued, as in the root executor. FBProbingFlowInstance is a test double that records what it is asked and can refuse. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FBParallelExecutor>>step now does the two things FBFlowExecutor>>step does around a transition: it asks the instance first (FBFlowInstance>>aboutToTransition:, where ApptiveBase counts its rate limits - a loop used to bypass them) and records an FBTransitionFollowed (a scope's log had no transitions at all). Both only for a transition actually followed, since inside a scope the branch condition is decided at the step; a refusal raised from the hook leaves the work item queued, as in the root executor.
FBProbingFlowInstance is a test double that records what it is asked and can refuse.