Drop the legacy shapes; a normalizer brings old stores to the current… - #143
Merged
Merged
Conversation
… one FBToken loses the id fields that stood in for #parent, #scope and #split before they were references, and with them the fallbacks that read them: FBBaseActivation>>legacySourceNode, the node key in FBJoinBehavior>>arrivalKey and FBJoinState>>sourceNodeOf:. A token persisted before is one without a parent, a scope or a pass. The two other half migrations go the same way: FBTransition no longer duck-types as a work item for raw transitions in a pending queue from before FBWorkItem, and the executors no longer read a single token where a queue of them is kept. Instead FBFlowInstance>> normalizePersistedQueues (FBBaseExecutor>>normalizeQueues) brings such queues to the current shape once - a raw transition becomes a work item, a single token a queue of one - over every executor of the instance and of its sub flow instances, answering whether it changed anything. ApptiveGrid runs it as a database migration. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… one
FBToken loses the id fields that stood in for #parent, #scope and #split before they were references, and with them the fallbacks that read them: FBBaseActivation>>legacySourceNode, the node key in FBJoinBehavior>>arrivalKey and FBJoinState>>sourceNodeOf:. A token persisted before is one without a parent, a scope or a pass.
The two other half migrations go the same way: FBTransition no longer duck-types as a work item for raw transitions in a pending queue from before FBWorkItem, and the executors no longer read a single token where a queue of them is kept. Instead FBFlowInstance>> normalizePersistedQueues (FBBaseExecutor>>normalizeQueues) brings such queues to the current shape once - a raw transition becomes a work item, a single token a queue of one - over every executor of the instance and of its sub flow instances, answering whether it changed anything. ApptiveGrid runs it as a database migration.