Fix broken/dead application-state accessor methods - #2
Merged
Merged
Conversation
GossipEndpoints>>endpointStateAt:put: called the nonexistent self localEndpoint (should be localEndpointState) and passed itself instead of a GossipEndpointState to setValue:endpointState: — never exercised (Gossiper's own addToList:/removeFromList: bypass it entirely). Fixed to delegate to the already-correct GossipEndpointState>>applicationStateAt:put:. Found two more of the same species while verifying the fix: Gossiper>>stateAt:/stateAt:put: had the identical bug (calling stateAt:/stateAt:ifAbsentPut: on a bare GossipEndpoint, which has no such method) and were likewise never called anywhere. Fixed the same way; verified end-to-end with a fresh Gossiper instance. Also removed GossipApplicationState>>initializeVersionFrom:, a dead self shouldBeImplemented stub with zero callers — version is computed in setValue:endpointState: via endpointState nextVersion instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GossipEndpoints>>endpointStateAt:put: called the nonexistent self localEndpoint (should be localEndpointState) and passed itself instead of a GossipEndpointState to setValue:endpointState: — never exercised (Gossiper's own addToList:/removeFromList: bypass it entirely). Fixed to delegate to the already-correct GossipEndpointState>>applicationStateAt:put:.
Found two more of the same species while verifying the fix: Gossiper>>stateAt:/stateAt:put: had the identical bug (calling stateAt:/stateAt:ifAbsentPut: on a bare GossipEndpoint, which has no such method) and were likewise never called anywhere. Fixed the same way; verified end-to-end with a fresh Gossiper instance.
Also removed GossipApplicationState>>initializeVersionFrom:, a dead self shouldBeImplemented stub with zero callers — version is computed in setValue:endpointState: via endpointState nextVersion instead.