Skip to content

Add tombstone GC for GossipListValue #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noha merged 1 commit into from
Jul 23, 2026
Merged

Add tombstone GC for GossipListValue #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions source/Gossip-Tests/GossipListValueTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
Class {
#name : 'GossipListValueTest',
#superclass : 'TestCase',
#category : 'Gossip-Tests',
#package : 'Gossip-Tests'
}

{ #category : 'as yet unclassified' }
GossipListValueTest >> testAddMakesItemPresent [
| lv |
lv := GossipListValue new.
lv add: #a.
self assert: (lv includes: #a).
self assert: lv presentItems asArray equals: #(#a)
]

{ #category : 'as yet unclassified' }
GossipListValueTest >> testGcTombstonesOlderThanKeepsRecentTombstones [
| lv |
lv := GossipListValue new.
lv add: #a.
lv remove: #a.
lv add: #b.
lv gcTombstonesOlderThan: 5.
self assert: (lv entries includesKey: #a)
]

{ #category : 'as yet unclassified' }
GossipListValueTest >> testGcTombstonesOlderThanNeverRemovesPresentItems [
| lv |
lv := GossipListValue new.
lv add: #a.
lv add: #b.
lv add: #c.
lv gcTombstonesOlderThan: 0.
self assert: (lv entries includesKey: #a).
self assert: lv presentItems asSortedCollection asArray equals: #(#a #b #c)
]

{ #category : 'as yet unclassified' }
GossipListValueTest >> testGcTombstonesOlderThanRemovesOldTombstones [
| lv |
lv := GossipListValue new.
lv add: #a.
lv remove: #a.
lv add: #b.
lv add: #c.
lv gcTombstonesOlderThan: 1.
self deny: (lv entries includesKey: #a)
]

{ #category : 'as yet unclassified' }
GossipListValueTest >> testRemoveTombstonesRatherThanDeletes [
| lv |
lv := GossipListValue new.
lv add: #a.
lv remove: #a.
self deny: (lv includes: #a).
self assert: lv presentItems isEmpty.
self assert: (lv entries includesKey: #a)
]
6 changes: 6 additions & 0 deletions source/Gossip/GossipListValue.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ GossipListValue >> entries [
^ entries
]

{ #category : 'as yet unclassified' }
GossipListValue >> gcTombstonesOlderThan: aVersionGap [
entries := entries reject: [ :pair |
pair first not and: [ (versionCounter - pair second) > aVersionGap ] ]
]

{ #category : 'not defined protocol' }
GossipListValue >> includes: anItem [
^ (entries at: anItem ifAbsent: [ ^ false ]) first
Expand Down
Loading