Register routes from the reachable pragmas, not the presenter's own - #8
Merged
Merged
Conversation
Route registration and link serialisation ask different questions of the same presenter. A variable segment has to register a route for every operation any specialisation under the base class may expose, long before it is known which concrete presenter serves a request - that is reachability. Serialising an object's _links asks what that one presenter offers, and gates it through isAllowed:. Both went through #allLinksPragmas, which collected over the whole subtree. Point route registration at #reachableLinkPragmas instead, which names the reachability question explicitly, so #allLinksPragmas is free to mean ordinary inheritance. No behaviour change on its own: #reachableLinkPragmas collects the same subtree #allLinksPragmas did. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route registration and link serialisation ask different questions of the same presenter. A variable segment has to register a route for every operation any specialisation under the base class may expose, long before it is known which concrete presenter serves a request - that is reachability. Serialising an object's _links asks what that one presenter offers, and gates it through isAllowed:.
Both went through #allLinksPragmas, which collected over the whole subtree. Point route registration at #reachableLinkPragmas instead, which names the reachability question explicitly, so #allLinksPragmas is free to mean ordinary inheritance.
No behaviour change on its own: #reachableLinkPragmas collects the same subtree #allLinksPragmas did.