Write a request snapshot to a byte stream - #9
Merged
Merged
Conversation
ZnMessage>>writeOn: writes bytes, but withStreamDo: opened the file with writeStream, a character stream with a UTF-8 encoder in front of it. Every byte above 127 was therefore encoded a second time: the C3 9F of an "ss" became C3 83 C2 9F, and a snapshot came out longer than the Content-Length it carried. A captured request from a German tenant read "FaaAYen" where the client had sent "Faassen", which is a good way to send someone looking for an encoding bug that is not there. The stack trace branch wrote text to that same stream, so it now encodes the trace itself before handing it over. The handler hard-codes /data/logs, so the test reaches it through a subclass that answers a directory of its own rather than opening up the production class. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZnMessage>>writeOn: writes bytes, but withStreamDo: opened the file with writeStream, a character stream with a UTF-8 encoder in front of it. Every byte above 127 was therefore encoded a second time: the C3 9F of an "ss" became C3 83 C2 9F, and a snapshot came out longer than the Content-Length it carried. A captured request from a German tenant read "FaaAYen" where the client had sent "Faassen", which is a good way to send someone looking for an encoding bug that is not there.
The stack trace branch wrote text to that same stream, so it now encodes the trace itself before handing it over.
The handler hard-codes /data/logs, so the test reaches it through a subclass that answers a directory of its own rather than opening up the production class.