Keep early owned CMake targets inside the licence gate - #48
Conversation
Signed-off-by: sammiller <dekueon@gmail.com>
|
Complete review of head 453007f: all three changed files reviewed against the accepted WP00.02 native declaration profile. The remote and local diffs have identical stable patch ID a334e62daadd52d88ad0d4f9a7f4b3387742b2ba. Only targets actually introduced by include(CTest) are exempt; pre-existing owned targets are checked with tests both enabled and disabled. The regression failed against the previous root and passes after this repair. Eleven licence tests, locked restore, both actual native profiles and four CTest tests, Release x64 IDE build and audited native staging passed locally. No unresolved finding. Merge remains gated on all applicable latest-head CI; main publication and public-package/consumer verification remain post-merge obligations. |
|
Post-merge verification passed for 4c18e2c. Main run 35406152509 succeeded including actual publication. All ten NuGet 1.0.0-ci.11.1 packages are publicly indexed and their downloaded contents match the immutable candidate. Clean source/effective reports cover all 35 projects on both OSes, Windows IDE declarations and eight actual native targets. Five isolated JIT/AOT consumers, C17 and four wrong/missing/tampered runtime rejection cases passed against this exact candidate. The primary checkout is pulled and clean; branches and worktrees remain. This closes the CTest repair and current DesktopPlatform WP00.02 declaration/candidate gates, without claiming future functional native capability or full product readiness. |
When an owned CMake target was declared before CTest, the root's blanket snapshot incorrectly exempted it from licence verification. Record only targets created by the CTest include, so early owned targets remain subject to the same declaration checks. The exemption is absent when native tests are disabled.
A regression exercises the actual root CMake file with native tests both on and off. It demonstrably fails against the previous root and passes after this fix. All 11 licence tests, both real Windows CMake builds/four native tests/install, audited native staging, and the required Windows IDE Release|x64 build passed (zero warnings/errors). Source inventory and whitespace checks also passed; all three files were reviewed.
This is the bounded WP00.02 post-merge review repair for #47. Latest-head CI is required before merge; main publication and public ten-package verification remain required afterward. Retain the branch/worktree.