Skip to content

adopt equivalence report: E1 explanation tells the operator to distrust a healthy cross-version adoption #97

Description

@arcaven

Under `--allow-version-change`, E1's FAIL line still reads "same-version trees should be identical — verify the store artifact before trusting the adoption" (round-2 pilot, ArcavenAE/aae-orc#128, N4 Med). The operator explicitly consented to version drift, differences are the expected result, and the report responds by telling them to distrust a healthy adoption.

Expected: the explanatory clause branches on version equality. Same versions: keep the current wording (differences genuinely are suspicious). Version drift: label the result along the lines of "EXPECTED (version drift): N differing paths between and ".

The pilot verified the FAIL itself was correct both times (a real rc.22 vs rc.23 content diff in agents/pr-manager.md, and differing dispatcher hashes); only the explanation is wrong. Relevant path: internal/adopt/adopt.go, equivalenceReport.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type.bugBroken behavior; something does not work as designed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions