finding(sideshow): findings 006 and 007 from the xorml harvest - #140
Merged
Merged
Conversation
…from the xorml harvest Refs: aae-orc-xorml, aae-orc-mobz8, aae-orc-wk92
arcavenai
approved these changes
Oct 2, 2026
arcavenai
left a comment
Member
There was a problem hiding this comment.
Approve at c05e69a. Merge recommended.
I traced every code claim against origin/main 1b5d716.
finding-006
checkContentCensus(internal/doctor/layer1.go:165) reads_config/files-manifest.csvfrom inside the store version (:170). That file arrives with the pack content, so the reference is replaced along with the content. The cited c33fdd2 (#137) is on main and predates #139, which is the right "before" anchor.- #139's
store-file-manifest(registered at layer1.go:29, implemented in internal/doctor/file_manifest.go) recomputes againstfile-manifest.csv. Its detail strings match the finding: "%d files match" at :112, and "%d differ (first: ...)", withmissingandunlistedgroups, at :115-122. - "The published r2 reports unavailable" is consistent with the artifact. I listed the published bmad-v6.12.0-r2 tarball: it carries no
file-manifest.csvamong its 2383 entries, because it predates sideshow-packs#40. - The 2023 count matches that release's sibling
file-manifest.csv(2023 rows). - The end-to-end overwrite result and the 2026-09-30 ruling are recorded as observed and relayed. I did not re-run the overwrite.
finding-007
InstallFromLocal(internal/pack/pack.go:439-637) doesMkdirAll,UnfreezeTree, then afilepath.WalkDircopy, thenverifyExecManifestat :569.- The only
os.Removecalls in the function are thecurrentsymlink at :590 and a registry entry at :601. Neither removes store files, so a version directory accumulates the union of its sources, as stated. - The survival of the earlier manifest in finding-006's run is what that code predicts.
Node
question-five-layer-doctorgains one dated "Layer 1 progress" paragraph that back-references both findings. Nothing else in the node changes, and the PR does not touch a charter.
Numbering, validation, redaction, style
- 006 and 007 are free: main ends at finding-005, and no other open PR adds a finding.
kos validateat head reports 7 findings with 0 duplicate-id failures. Its 5 graveyard-section warnings are on existing nodes, are identical on main, and none are in this diff.- I scanned the title, body, commit message and diff for org, client, environment, host and home-path tokens and for instance ids, and found none. A positive control confirmed the pattern matches. The only em dash is the kos separator in the commit subject.
- There is no first-person plural. The open questions in finding-007 are left open rather than decided.
Member
|
Correction to my review 5391307474 (the verdict stands). I wrote that
That warning comes from a cross-graph edge the node already carries. The PR does not cause it: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two lessons from the xorml work change how doctor findings and reinstalls should be read, and the graph holds neither. Docs only.
item: harvest of aae-orc-xorml half 2 (#138, #139) and aae-orc-mobz8.
changes
question-five-layer-doctor: a layer-1 progress paragraph back-referencing both.gates:
kos validate(7 findings, 0 failures); YAML parses; no em dash outside the kos separator, no banned words, no host names or home paths.blast radius:
_kos/only.Refs: aae-orc-xorml, aae-orc-mobz8, aae-orc-wk92