Repository navigation
docs(shots): update the guide for CLI 0.56.8 - #97
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem and author intent
The public Shots skill still describes missing upload preferences as manual and tells users to install helper npm packages. ArchDev CLI 0.56.8 defaults uploads to automatic behind the local setting and server rollout flag, and includes the helper tools. Agents following the old guide can misinterpret settings and install unnecessary packages.
What changed
Describe the 0.56.8 default, retained manual opt-outs, and the difference between unsetting the preference and turning uploads off. Explain session-only Stop uploads and auth/rollout admission. Give reviewed unattended harnesses an explicit manual preference so they continue to keep captures local.
Replace obsolete helper-install instructions with bundled-distribution diagnostics, fixture-owned React/Ink dependencies, and supported Node-runtime requirements. Passive doctor output does not prove runtime compatibility. Regenerate the eight harness skill copies from the root guide.
Scope: documentation only. No CLI runtime changes. The canonical CLI fetches the public skill from main; version-tagged plugin consumers receive it through their normal plugin update/release path.
Verification
shots doctor --jsonconfirms bundled helper readiness and passive-runtime limitations.a_stop_hook_defaults_to_uploading_only_the_sessions_captures,manual_mode_uploads_nothing_on_stop, andautomatic_upload_auth_and_offline_failures_are_silent_and_retryable, exercise the default and its gates through the actual CLI/worker and fixture HTTP. These passed in implementation PR 21977; generator tests alone are not evidence of runtime semantics..github/workflows/plugins.ymlruns generator typecheck, tests, and consistency checks on PRs. Existing bootstrap/installer workflows also run. No new tests or targets; documentation-only change, with no new end-to-end behavior to prove.Risk and follow-up
Low runtime risk: instructions and generated copies only. Upload permission wording preserves explicit manual/off choices. This does not enable the server rollout flag. Shots remains staff/development-gated; the companion firstlanding changelog PR keeps its announcement as a draft until verified general availability.