Repository navigation
feat(notifications): enforce configurable batch size limit with chunk isolation (#1934) - #2076
Closed
ryder777777 wants to merge 1 commit into
Closed
ryder777777 wants to merge 1 commit into
ryder777777 wants to merge 1 commit into
Conversation
Author
|
/claim #1934 Payout Wallet (Binance USDT TRC20 / Tron Network): |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1934
Summary
Add configurable
batchSizeLimit(setBatchSizeLimit/getBatchSizeLimit, default50) and sequential chunking with per-chunktry/catchisolation inNotificationGeneratorService.createNotificationsBatchso large fan-out batches never exceed database parameter limits and a failed chunk does not abort remaining chunks.Modified Files
backend/src/notifications/notification-generator.service.tsbackend/src/notifications/notification-generator.service.spec.tsVerification
npx eslint(0 errors) andnpx jestunit tests passing inbackend/.