Repository navigation
fix(leaderboard): preserve snapshot consistency during rank recompute (#1932) - #2086
Open
huangji6693-max wants to merge 1 commit into
Open
huangji6693-max wants to merge 1 commit into
huangji6693-max wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1932
Summary
recalculateRanks()begins mutating entries.getLeaderboard,getTopN,getLeaderboardCursor,getUserRank) from the frozen prior snapshot while recomputation is in flight so readers never observe partially updated ranks or mixed scores.Files Modified
backend/src/leaderboard/leaderboard.service.tsbackend/src/leaderboard/leaderboard.service.spec.tsVerification
npx jest src/leaderboard/: 4/4 test suites passed, 79/79 tests passed (including tests verifying reads during recompute return the complete prior snapshot, reads after recompute return the new snapshot, atomic swap across step-by-step writes with zero partial state, and rollback safety).