Skip to content

[Bug]: on Tabs... #566

Closed
Closed

Description

@jindradev

Describe the bug

The Tabs settings are a mess

  • features are not properly disabled for non-paid users
  • Rounded Tabs are a mess
    • "more rounded" with no option for roundness
    • "a padding" with no control
    • does not work well with "Tab Height"
    • sets tab background color
    • Tab Highlight Position in the current form makes absolutely no sense for Rounded Tabs
    • looks even worse in vertical layout
  • Tab Height is a slider with no visible value why??? Trees Custom Item Line Height is a number
  • advise where to find "hide the close button"
  • Tab Highlight Position - does not make sense in vertical layout but honestly I understand this one
  • Tabs Shadow - I would at least specify you mean Tab Bar, not plural of Tab
  • Tab Separators - explain when Tab Separators even show up
  • Tab Active Highlight Color - sure if anybody uses that. But for a paid feature I would expect some finesse - highlight via background color, gradient, definitely a glow option

To Reproduce

  1. install the extension
  2. open Tabs menu
  3. suffer

Expected behavior

See Bug Description. There are problems with the new Rounded Tabs stemming from a complex configuration that needs to be redone in the first place.

Material Theme Version

v9.0.0

IDE

IntelliJ IDEA

System Info

Logs/Screenshots

Activity

  1. mallowigi commented on Apr 25, 2025

    @mallowigi
    Collaborator

    Let's handle things separately shall we:

    features are not properly disabled for non-paid users

    Which features?

    Rounded Tabs are a mess:
    "more rounded" with no option for roundness
    "a padding" with no control

    There is no incentive in adding that much customization. It's just rounded tabs similar to what we can find in other tabbed applications such as Fleet.

    I'm currently changing a bit the design to look more like Fleet:

    Image

    However, this is still a feature in progress, so suggestions are welcome!

    does not work well with "Tab Height"

    What do you mean by that? I took a look and I understand that when tab height is at the minimum, the rounded tabs appear very squished and unsightly. However, this can be fixed simply by... increasing the height until you get a satisfying design, isn't it?

    sets tab background color

    Again, what do you mean by that?

    Tab Highlight Position in the current form makes absolutely no sense for Rounded Tabs

    I was also hesitant about that, but in general I think it can still look good with rounded tabs, especially for setups like left-right or top-bottom. But more importantly, this can be turned off, so this should also be fine.

    looks even worse in vertical layout

    This is subjective, I don't see what issues there are in setups like this:

    Image

    Tab Height is a slider with no visible value why??? Trees Custom Item Line Height is a number

    Design choice. In a nutshell, its because the range is larger, so its easier to select rather than clicking up/down a lot of times. Of course this is at the price of precision but 1 or 2 pixels do not make a big difference

    advise where to find "hide the close button"

    Unrelated to the plugin, it's in the Tabs Settings of the IDE

    Tabs Shadow - I would at least specify you mean Tab Bar, not plural of Tab

    Well, maybe. But this has been the case for ages now, it doesn't make a lot of sense to change it just now.

    Tab Separators - explain when Tab Separators even show up

    I agree with this one. It's this, but I agree it's very subtle. Maybe I should increase the contrast, please create a ticket about this.

    Image

    Tab Active Highlight Color - sure if anybody uses that. But for a paid feature I would expect some finesse - highlight via background color, gradient, definitely a glow option

    Can you elaborate? This could be a good idea, but please make it in a separate ticket. What do you mean by glow?

  2. mallowigi commented on Apr 25, 2025

    @mallowigi
    Collaborator

    In general I'm very welcome to suggestions to this feature. It's still opt-in but the motivation is to create tabs similar to what you can find in Fleet, Safari, Forklift and other applications that embrace these new tab styles.

    As I said I don't want to introduce too much customization because it can turn off users, good defaults are the way to go. Therefore, the current padding is fine most of the time, except when tab height is too small or too large.

  3. locked and limited conversation to collaborators on Apr 25, 2025
  4. converted this issue into a discussion #567 on Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions