fix: 1.4.35 hotfix: demo file names and path (#35), upload log wording, database.json kept on update

[sivert-io]

Hotfix for the 1.4.x line, which the current platform (2.x and the 3.0 betas) talks to. Branched from v1.4.34, not dev (dev has the 2.0.0 rename). This doesn't change any name, header or convar, so it works with the current platform. Not released; the version is still 1.4.34 and release.sh patch makes it 1.4.35.

Changes

1. Demo file names are safe (fixes [QUESTION] How does the demo work? #35). The name was matchzy_demo_name_format with only spaces replaced, so a workshop map (workshop/<id>/de_mirage) put slashes in it, and team names with / \ : ; " ' | ? * or symbols like the reporter's SadBoy ♥ broke tv_record (or ; split the command). New src/DemoFileName.cs (no CounterStrikeSharp dependency, unit tested) builds the file name:
   • keeps ASCII letters, digits, -, _, .; everything else becomes _; repeats of _/. collapse; _/. are trimmed from the ends (no hidden files, no ..); capped at 180 characters
   • {MAP} is the last segment of a workshop map name
   • never empty: falls back to {TIME}_{MATCH_ID}
   • only the file name; the matchzy_demo_path folder is left as configured
   • Non-ASCII letters are transliterated, not kept (Команда → Komanda, Café → Cafe; other scripts and symbols → _). The name is also sent in the MatchZy-FileName / Get5-FileName upload headers, and I checked in the .NET 8 SDK image: HttpClient refuses non-ASCII header values (Request headers must contain only ASCII characters). So a Cyrillic or ♥ demo name could never be uploaded, even if tv_record wrote it.
   • activeDemoFile, the demo events and the upload all use this name, and the upload's fallback search (DemoFileLocator) now looks for the same {MAP} token.
   • Names that were already safe come out the same as before (2026-09-24_20-57-56_9_de_mirage_Team_A_vs_Team_B).
2. Demos are recorded where the plugin looks for them ([QUESTION] How does the demo work? #35). tv_record got a relative path, and a relative path lands in the first writable Game search path. Metamod puts csgo/addons/metamod first in gameinfo.gi, so demos were written to csgo/addons/metamod/MatchZy/ while the plugin logged, and later searched, csgo/MatchZy/. This probably also caused the platform's demo uploads failing with file_not_found on Metamod servers, which is every csm server.
   • tv_record now gets the absolute path <game>/csgo/<demo path><file>.dem. The reporter's manual tv_record /home/container/game/csgo/MatchZy/testdemo shows CS2 accepts that. The logged "Full path" is now the path actually used.
   • Windows: the path uses / separators (backslashes in the game directory are converted, and Windows accepts /), and it is quoted only when it contains a space, e.g. under Program Files. The usual Linux path is passed unquoted, exactly like the reporter's command. I couldn't try a Windows server.
   • The upload search (DemoFileLocator.CandidateDirectories) also looks in csgo/addons/metamod/<demo path> and csgo/addons/metamod, so demos recorded by older builds, or if an absolute path is ever refused, are still found.
   • A matchzy_demo_path without a trailing / no longer runs into the file name (MatchZy2026-…dem).
3. Upload logs name the right file (from the [QUESTION] How does the demo work? #35 log). Round backup JSON files go through UploadFileAsync too. Without an upload URL (plugin used without the platform), every round logged three lines calling MatchZyDataBackup/matchzy_9_0_round00.json a "Demo file". Now it's one line per match and file kind, naming the kind and its convar (matchzy_demo_upload_url or matchzy_remote_backup_url). Round backup uploads log [BACKUP_UPLOAD] markers and no longer send demo_upload_* events or the "Demo upload succeeded" chat line. [DEMO_UPLOAD] markers for demos are unchanged; neither the platform nor csm parses them.
4. Backport of fix(practice): add mp_roundtime_hostage to prac.cfg #29: mp_roundtime_hostage 60 in prac.cfg.
5. Backport of fix: title GitHub releases as Auto Tournament CS2, not MatchZy #30: GitHub releases are titled "Auto Tournament CS2 v…". The asset stays MatchZy-<version>.zip.
6. database.json is no longer in the release zip (the one fix in feat!: rename the plugin to Auto Tournament CS2 (2.0.0) #32 that doesn't depend on the rename). The shipped SQLite default overwrote an operator's MySQL database.json on every update, so their match history seemed to disappear. The plugin already writes the default when the file is missing. The zip layout (MatchZy-<version>/addons, /cfg) is unchanged.
7. The release script works from this branch:
   • gh release create --target <release commit>. Without it, GitHub creates the tag on the default branch (dev, 2.x).
   • The changelog (release notes and Discord) starts at the newest tag reachable from HEAD, not the newest tag in the repo (v2.0.0).
   • It checks the zip (DLL and config.cfg there, no database.json) before committing or publishing anything. unzip is added to the workflow's apt line.
   • It refuses non-1.x versions, a detached HEAD, and a tag that already exists on origin.
   • The Discord post uses the Auto Tournament CS2 name and links to Auto-Tournament/cs2-plugin.
   • It keeps --latest, so 1.4.35 becomes "latest" and v2.0.0 stays a pre-release.

Not backported

• Everything else in feat!: rename the plugin to Auto Tournament CS2 (2.0.0) #32 and the licence commits (chore(license): add the Auto Tournament copyright line #33, chore(license): our copyright line starts in 2023 #34): the rename, the carry-over and the new zip layout need plugin 2.0.0 and platform 3.0.

Verification

• mcr.microsoft.com/dotnet/sdk:8.0: dotnet build -c Release has 0 errors, and dotnet test tests/MatchZy.Tests passes 321 tests. 37 new DemoFileNameTests cases: workshop map, SadBoy ♥, / \ : ; " ' | ? * < >, emoji, Cyrillic, accents, CJK fallback, empty format, length cap, and the fallback search finding the sanitised name. 10 new DemoFileLocatorTests cases: absolute tv_record path (Linux, trailing slashes, empty and leading-slash demo paths, Windows backslashes), quoting only with spaces, the Metamod folders in the search list, and a demo recorded under addons/metamod/MatchZy/ being found.
• I ran the packaging part of release.sh in the same image. MatchZy-1.4.35.zip has addons/counterstrikesharp/plugins/MatchZy/MatchZy.dll and cfg/MatchZy/* without database.json.

Releasing 1.4.35

Merge this into hotfix/1.4.x, then run the Release workflow on hotfix/1.4.x: gh workflow run release.yml -R Auto-Tournament/cs2-plugin --ref hotfix/1.4.x -f bump_type=patch. It commits "Release v1.4.35" to hotfix/1.4.x, pushes that branch only, tags that commit v1.4.35 and marks it latest. It doesn't touch dev.

🤖 Generated with Claude Code