Keep PHP diagnostics out of WP-CLI stdout - #4731
Open
chubes4 wants to merge 1 commit into
Open
Conversation
PHP 8.5 deprecations from bundled WP-CLI code were written to stdout, which breaks machine-readable JSON and other parsed command output. Apply the reprint runner ini policy so WP-CLI launchers send diagnostics to stderr (and suppress E_DEPRECATED) on both native and Playground paths.
Collaborator
📊 Performance Test ResultsComparing 360fd86 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
OpenAI gpt-5.6-sol, via OpenCode general coding subagent, reproduced PHP 8.5 deprecations on
studio wpstdout, comparedrun-wp-cli-commandwith the reprint runner PHP ini policy, implemented the launcher-level fix, added focused tests, ran lint/test gates, and opened this PR under human direction.Proposed Changes
studio wpcan emit PHP 8.5 deprecations on stdout before command output, which corrupts machine-readable JSON and other parsed results even when WP-CLI itself succeeds.The reprint runner already suppresses
E_DEPRECATEDand routes displayed errors to stderr. This PR applies that same PHP ini policy at the WP-CLI launcher so native-dflags and PlaygroundsetPhpIniEntrieskeep stdout strictly parseable.Testing Instructions
npm test -- apps/cli/lib/tests/wp-cli-php-ini.test.tsstudio wp plugin list --format=json(after a CLI build that includes this change) and confirm stdout is valid JSON with noDeprecated:prefix. Diagnostics, if any, belong on stderr.Pre-merge Checklist