build(deps): bump @types/node to 26.x in dev tools (split from #4587) - #4744
Open
epeicher wants to merge 1 commit into
Open
build(deps): bump @types/node to 26.x in dev tools (split from #4587)#4744epeicher wants to merge 1 commit into
epeicher wants to merge 1 commit into
Conversation
Collaborator
📊 Performance Test ResultsComparing d154941 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code investigated #4587, reproduced its CI failure locally, identified which half of the dependency group was safe to land, regenerated the lockfile, and ran the verification below. I reviewed the resulting diff.
Proposed Changes
Dependabot's
typescriptgroup PR (#4587) bundled a TypeScript 6 → 7 major bump together with routine@types/nodeupdates. TypeScript 7 can't land yet:typescript-eslinthard-errors when it loads against TS 7 (Error: typescript-eslint does not support TS 7.0), andknip's peer range (typescript >=5.0.4 <7) makesnpm cifail outright — which is why every job on #4587 failed within two minutes. Upstream support is tracked in typescript-eslint/typescript-eslint#10940 and targets TS ≥ 7.1, with no timeline.This PR takes only the part that is safe today:
@types/node25.9.3 → 26.4.0 in the two dev-only tool workspaces (tools/benchmark-site-editor,tools/compare-perf). Both are devDependencies of local tooling, so there is no runtime or user-visible impact. TypeScript stays on 6.0.3 and can be revisited oncetypescript-eslintsupports 7.The remaining bumps listed in #4587 (
@tsconfig/node10,@types/express-serve-static-core,@types/hast) are transitive patch updates that need no manifest change and will ride along on a future Dependabot run.Testing Instructions
Run from a clean checkout of this branch:
npm ci— completes with no ERESOLVE error (this is the step that fails on build(deps): bump the typescript group across 1 directory with 5 updates #4587)npm run lint— passes (0 errors; 2 pre-existing warnings in files this PR does not touch)npm run typecheck— passes across all 7 workspacesPre-merge Checklist