Repository navigation
GroupModel: allow creating a group with no models - #322
Open
IbrarYunus wants to merge 1 commit into
Open
IbrarYunus wants to merge 1 commit into
IbrarYunus wants to merge 1 commit into
Conversation
Member
|
Hi @IbrarYunus thanks for making this PR! Your update makes a ton of sense. There is a small modification I would add, just to make sure that things behave correctly wrt In the imports change it to: from caskade import forward, NodeListAnd your modification would become: if models is None:
models = NodeList([])That way when you add models later they will be properly integrated into the parameter graph. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GroupModel.__init__defaultsmodels=Nonebut then iterates over it, so creating an empty group to fill later fails:Noneis now treated as an empty list. The group model tests pass.