Repository navigation
Release 1.21.0: send the environment as deployment.environment.name (runtime-node 1.17.0) - #59
Merged
Merged
Conversation
…runtime-node 1.17.0) OpenTelemetry's semantic conventions renamed the resource attribute deployment.environment to deployment.environment.name. Every Autter ingester reads both and prefers the new name, but Autter's own SDKs and docs still set the old one, which the monorepo's observability gap finder (Plan 034 WP4) now flags as deprecated in customers' code. - runtime-node: initAutterServer sends deployment.environment.name on spans and metrics (log records already did). A value in OTEL_RESOURCE_ATTRIBUTES still wins under either name: the NodeSDK merges those over the SDK's resource, and a value under the old name is now also sent under the new one, so it is not overridden by the SDK's own default. verify uses the new name. environmentFromResourceAttributes() reads it, percent-decoded. - Python adapter: the test-run environment and the compat.py verify event use deployment.environment.name; an environment the service sets, under either name, still wins and is left as set. - Docs, examples and the ingester README use the new name; the ingester's fallback to the old name and its old-name fixtures are kept. - runtime-node 1.17.0, CHANGELOG 1.21.0. Behaviour change for a collector of the user's own that reads deployment.environment from Autter's Node spans. Tests: runtime-node 289 pass, 4 skipped; Python adapter 109 pass, 1 skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenTelemetry's semantic conventions renamed the resource attribute
deployment.environmenttodeployment.environment.name. Every Autter ingester reads both and prefers the new name (since v0.1), but Autter's own SDKs and docs still set the old one, which the monorepo's new observability gap finder (Plan 034 WP4) flags as deprecated in customers' code.Changes
initAutterServersendsdeployment.environment.nameon spans and metrics; log records already did.npx @autter/runtime-node verifyuses the new name too.OTEL_RESOURCE_ATTRIBUTESstill wins under either name. The NodeSDK merges those values over the SDK's resource. A value under the old name is now also sent under the new one, so the SDK's own default doesn't override it. Before this change the two shared one key, so the user's value won simply by replacing it.environmentFromResourceAttributes()reads that value (trimmed and percent-decoded).compat.py verifytest event usedeployment.environment.name.runtime-node1.17.0 and CHANGELOG 1.21.0. This is a behaviour change only for a collector of the user's own that readsdeployment.environmentfrom Autter's Node spans or from the Python adapter's test environment.Tests (Windows)
runtime-node: 289 pass, 4 skipped. The environment test now checks the old-name override end to end against a local collector.unittest discover -s adapters/python, pinned requirements): 109 pass, 1 skipped.Release
After merge, tag
v1.21.0. The Release workflow publishes only@autter/runtime-node@1.17.0; every other package keeps a version that is already on npm, so it is skipped.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.