[Bug] MenuBuilder does not return options list for MenuBar control

[zohaibhanif]

Description

I am using MenuBuilder class to register menu options for MenuBar control. But it does not return options list when GetOptions method is called.

Steps to reproduce

1. Add a page for MenuBar and inject IMenuBuilder dependency in it.
2. Register MainMenuOptions using RegisterOption provided in MenuBuilder.

menuBuilder.RegisterOption(new MainMenuOption { FontFamily = string.Empty, Glyph = string.Empty, Priority = 3, Text = "Badge View", Uri = "BadgeViewPage" });
menuBuilder.RegisterOption(new MainMenuOption { FontFamily = string.Empty, Glyph = string.Empty, Priority = 1, Text = "Image Entry", Uri = "ImageEntryPage" });
menuBuilder.RegisterOption(new MainMenuOption { FontFamily = string.Empty, Glyph = string.Empty, Priority = 2, Text = "Borderless Date Picker", Uri = "BorderlessDatePickerPage" });
menuBuilder.RegisterOption(new MainMenuOption { FontFamily = string.Empty, Glyph = string.Empty, Priority = 4, Text = "Repeater View", Uri = "RepeaterViewPage" });
MenuOptions = menuBuilder.GetOptions();

3. Get menu options list through GetOptions method.

Expected Behavior

It should return sorted menu options list based on priority.

Actual Behavior

It returns empty list.

Basic Information

• Version with issue: AP.MobileToolkit - 3.0.0-ci
• Xamarin.Forms version: 4.2.0.815419
• IDE: Visual Studio 2019 Professional - Version 16.3.5

Reproduction Link

Project: ToolkitDemo
Branch: issue/75/Demo-User-Controls

[dansiegel]

this is an issue within the sample project. you will need to address this

[zohaibhanif]

this is an issue within the sample project. you will need to address this

I debugged MenuBuilder to figure out the problem and my finding are given below:

1. MenuBuilder.RegisterOption method executes with the option as parameter. It adds option to Options collection.
   

2. Options.ReplaceRange method executes with the sorted list as parameter. In this method, it shows the item in the collection parameter.
   

3. When Items.Clear method executes, it clears up the Items list as well as collection parameter.
   

4. Options list in MenuBuilder gets empty.