Fix: Enforce type safety, test discovery, and build portability - #3
Open
mertcano wants to merge 1 commit into
Open
Fix: Enforce type safety, test discovery, and build portability#3mertcano wants to merge 1 commit into
mertcano wants to merge 1 commit into
Conversation
This PR addresses workspace-wide technical debt by eliminating unsafe any types, restoring deterministic Python test execution, and migrating POSIX-specific build scripts to a portable Node.js implementation. Type Boundaries: Replaced unbounded any types with unknown and Record<string, unknown> across API routes, local storage, and task parameters. Safe Module Loading: Implemented strict interfaces (MujocoLoader, MujocoImport) and runtime narrowing for dynamic MuJoCo imports. Added instanceof Error checks for safe virtual filesystem operations. Test Discovery: Added pythonpath = ["."] to pyproject.toml to resolve ModuleNotFoundError during pytest collection. Cross-Platform Compatibility: Replaced hardcoded Linux mkdir/cp shell commands in package.json with a portable fs/promises Node.js script (copy-mujoco.mjs) to support Windows build environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses workspace-wide technical debt by eliminating unsafe any types, restoring deterministic Python test execution, and migrating POSIX-specific build scripts to a portable Node.js implementation.
Type Boundaries: Replaced unbounded any types with unknown and Record<string, unknown> across API routes, local storage, and task parameters.
Safe Module Loading: Implemented strict interfaces (MujocoLoader, MujocoImport) and runtime narrowing for dynamic MuJoCo imports. Added instanceof Error checks for safe virtual filesystem operations.
Test Discovery: Added pythonpath = ["."] to pyproject.toml to resolve ModuleNotFoundError during pytest collection.
Cross-Platform Compatibility: Replaced hardcoded Linux mkdir/cp shell commands in package.json with a portable fs/promises Node.js script (copy-mujoco.mjs) to support Windows build environments.