Skip to content

Fix asymmetric mujoco-assets/ prefix matching in buildZipCandidates #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
midasbal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix asymmetric mujoco-assets/ prefix matching in buildZipCandidates #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions src/lib/mujoco-asset-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,20 @@ function normalizeZipPath(path: string): string {

function buildZipCandidates(assetPath: string): string[] {
const normalized = normalizeZipPath(assetPath);
const withoutUnderscorePrefix = normalized.startsWith("mujoco_assets/")
? normalized.slice("mujoco_assets/".length)
: normalized;
const withoutHyphenPrefix = normalized.startsWith("mujoco-assets/")
? normalized.slice("mujoco-assets/".length)
: normalized;
const candidates = new Set<string>();
// Strip whichever known prefix is present to get a prefix-agnostic stem,
// so both prefix flavors resolve to the same candidate set.
let stem = normalized;
if (stem.startsWith("mujoco-assets/")) {
stem = stem.slice("mujoco-assets/".length);
} else if (stem.startsWith("mujoco_assets/")) {
stem = stem.slice("mujoco_assets/".length);
}

const candidates = new Set<string>();
candidates.add(normalized);
candidates.add(withoutUnderscorePrefix);
candidates.add(withoutHyphenPrefix);
candidates.add(`mujoco-assets/${withoutUnderscorePrefix}`);
candidates.add(`mujoco_assets/${withoutUnderscorePrefix}`);
candidates.add(stem);
candidates.add(`mujoco-assets/${stem}`);
candidates.add(`mujoco_assets/${stem}`);

return Array.from(candidates).filter(Boolean);
}
Expand Down