feat(checker): add PositionDeltaChecker matching Hub usage - #8
Open
keyneszeng wants to merge 1 commit into
Open
Conversation
Adds a checker that succeeds when a body's position has moved past a per-axis threshold relative to a captured baseline. Mirrors Hub production usage (e.g. 'rotate the rolling pin 30 deg', 'move object 2cm left'). Mirrors the Python implementation added in the companion PR to AxisDataCleaning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a checker that succeeds when a body's position has moved past a per-axis threshold relative to a captured baseline. Mirrors Hub production usage (e.g. 27rotate the rolling pin 30 deg27, 27move object 2cm left27).
Task config schema (matches Hub)
{ "type": "PositionDeltaChecker", "sample_body": "akita_black_bowl_1_main", "axes": ["x", "y"], "min_delta_x": 0.018, "max_delta_x": -0.018, "capture_runtime_initial": true }Cross-repo coordination
Companion Python PR mirrors the algorithm. JS uses
captureRuntimeInitial: trueto capture the first-observed body position as baseline; Python offline validation passes the baseline explicitly viainitialPosition(since it is stateless per call).Verification
check()returns expected boolean for min/max delta, multi-axis OR semantics.Checklist
getStatus()reports per-axis deltas vs baselinereset()re-captures the runtime baselineallow_reentrysemantics consistent with composite pattern