[eno] Fix readiness handling for deleted tombstone resource - #647
Open
Ruinan Liu (ruinan-liu) wants to merge 2 commits into
Open
[eno] Fix readiness handling for deleted tombstone resource#647Ruinan Liu (ruinan-liu) wants to merge 2 commits into
Ruinan Liu (ruinan-liu) wants to merge 2 commits into
Conversation
Ruinan Liu (ruinan-liu)
requested review from
Robbie Zhang (robbiezhang),
Tingting Liu (tilnl) and
xiazhan
as code owners
September 4, 2026 18:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENO continued evaluating normal readiness expressions after tombstoned resources had been successfully deleted. Because readiness expressions cannot pass when the target object no longer exists, the ResourceState remained
Deleted=trueandReconciled=truebutReady=nil, leaving the Composition stuck inNotReady.This change identifies deletion snapshots before evaluating normal object readiness. Once deletion is confirmed, ENO treats deletion completion as the tombstone's terminal readiness state. This preserves existing readiness and deletion ordering while allowing the Composition to become ready.
Added unit, integration, ordering, ResourceSlice aggregation, and live-cluster E2E coverage for removing a readiness-enabled Service in a subsequent synthesis