Repository navigation
feat!: adopt laravel-okta v2 configurable route paths - #1
Merged
Merged
Conversation
…code/*)
Bumps bbs-lab/laravel-okta to ^2.0, whose default Okta paths change from
okta/* to authorization-code/*:
- login -> {nova-path}/authorization-code/redirect
- callback -> {nova-path}/authorization-code/callback
- logout -> {nova-path}/authorization-code/logout
- logout -> {nova-path}/authorization-code/callback/logout
NovaOktaPanel extends ConfigOktaPanel, so the paths are configurable per app
via the base okta.paths.* config (par config pour Nova) and inherited for free.
Route names, the login override and the two-factor.login bridge are unchanged.
Updates tests, README and CHANGELOG.
BREAKING CHANGE: update the Sign-in and Sign-out redirect URIs in the Okta
admin console to the new authorization-code/* paths, or logins fail with a
redirect_uri mismatch. An explicit services.{driver}.redirect still wins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adopts bbs-lab/laravel-okta v2.0: bumps the constraint to
^2.0and picks up the new default Okta route paths.{nova-path}/okta/login{nova-path}/authorization-code/redirect{nova-path}/okta/callback{nova-path}/authorization-code/callback{nova-path}/okta/logout{nova-path}/authorization-code/logout{nova-path}/okta/callback/logout{nova-path}/authorization-code/callback/logoutConfigurable per app via the base
okta.paths.*config (par config pour Nova) —NovaOktaPanel extends ConfigOktaPanel, so it inheritspath()for free, no new code.Unchanged
Route names (
nova-okta.login/.callback/.logout/.callback.logout), the login override, the branded login screen and thetwo-factor.loginbridge (okta/two-factor-challenge) — all untouched.Update the Sign-in and Sign-out redirect URIs in the Okta admin console to the new
authorization-code/*paths, or logins fail with aredirect_urimismatch (400). An explicitservices.{driver}.redirectstill wins.Released as v2.0.0.
Tests
Pest 51 tests / 141 assertions · PHPStan level 8 · Pint · 100% coverage · 100% MSI (mutation).