Repository navigation
feat!: adopt laravel-okta v3 logout path alignment - #2
Merged
Merged
Conversation
Bumps bbs-lab/laravel-okta to ^3.0, whose default logout paths align on the
common Okta convention:
- sign-out redirect URI (nova-okta.callback.logout):
nova/authorization-code/callback/logout -> nova/authorization-code/logout
- logout initiator (nova-okta.logout):
nova/authorization-code/logout -> nova/authorization-code/logout/redirect
NovaOktaPanel inherits path() so no src change; route names unchanged, the 2FA
bridge and menu wiring keep working. Updates test URI assertions, README and
CHANGELOG.
BREAKING CHANGE: from v2.0.0, point the Okta Sign-out redirect URI at
{nova-path}/authorization-code/logout (from v1.x or a standard Okta app already
whitelisting it, nothing to do). Sign-in side unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adopts bbs-lab/laravel-okta v3.0 (
^3.0): the default logout paths align on the common Okta convention.nova-okta.callback.logout){nova-path}/authorization-code/callback/logout{nova-path}/authorization-code/logoutnova-okta.logout){nova-path}/authorization-code/logout{nova-path}/authorization-code/logout/redirectNovaOktaPanelinheritspath()→ no src change. Route names, the login override and thetwo-factor.loginbridge are unchanged;route('nova-okta.logout')still initiates logout.From v2.0.0, point the Okta Sign-out redirect URI at
{nova-path}/authorization-code/logout(from v1.x or a standard Okta app already whitelisting it, nothing to do). Released as v3.0.0.Tests
Pest 51 tests / 141 assertions · PHPStan level 8 · Pint · 100% coverage · 100% MSI. Logout tests are name-based; URI assertions updated.