Repository navigation
Conversation
|
@damilareojetunde Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
p3ris0n
force-pushed
the
feature/vault-dashboard-issues-1244-1248
branch
from
October 20, 2026 21:33
a288a96 to
321f954
Compare
p3ris0n
force-pushed
the
feature/vault-dashboard-issues-1244-1248
branch
from
October 21, 2026 08:00
b70245d to
b4bcc80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minSharesOutto the vault client.The current vault contract has no withdrawal fee, so redemption previews show the contract's gross pro-rata amount with no fee deduction. The contract/API also does not expose per-wallet historical cost basis; the position's yield is therefore labeled as an estimate against a 1:1 share basis.
Fixes #1244
Fixes #1246
Fixes #1247
Fixes #1248