-
Notifications
You must be signed in to change notification settings - Fork 0
Annual Position Review Button #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johnlolonga19
wants to merge
20
commits into
dep_portal_ad_ManageDepartments
Choose a base branch
from
annual-position-review-John
base: dep_portal_ad_ManageDepartments
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
643d58e
created a branch off of dep_portal_ad_ManageDepartments and then add…
johnlolonga19 8bbf144
added Annual positionn review email template
johnlolonga19 5b76836
Add sendAnnualPositionReviewRequests logic for Annual Position Review
johnlolonga19 3361ecb
Add POST route to trigger Annual Position Review requests
johnlolonga19 f9091b0
add js to anchor the request button and emailTemplates.js link to the…
johnlolonga19 338844b
manageDepartments.html: handle functionality of the Annual Position r…
johnlolonga19 9a31d84
added the test suite for the logic
johnlolonga19 6fb8246
fixed some requested changes
johnlolonga19 667112d
Merge branch 'dep_portal_ad_ManageDepartments' into annual-position-r…
johnlolonga19 73eaeb0
fixed requested change to validate rsp and academicYear
johnlolonga19 60a30f8
removed the duplicate fuction
johnlolonga19 d088351
ressolve changes
johnlolonga19 fd6e4c5
changes to route
johnlolonga19 48d3a54
ressolve changes
johnlolonga19 f6366b3
Merge branch 'dep_portal_ad_ManageDepartments' of https://github.com/…
johnlolonga19 80aa951
fix damages caused by merge conflicts
johnlolonga19 b92ba12
consolidated the try and accept
johnlolonga19 f0f122e
Fold Annual Position Review into emailHandler instead of a separate m…
johnlolonga19 829421e
remove dropdown for MD page
johnlolonga19 9279efc
used g.currentyear and added demo data
johnlolonga19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| from app.models import * | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should try to work off from positionhistory model |
||
| from app.models.department import Department | ||
| from app.models.term import Term | ||
| from app.models.user import User | ||
|
|
||
|
|
||
| class PositionReview(baseModel): | ||
| academicYear = ForeignKeyField(Term) | ||
| department = ForeignKeyField(Department) | ||
| requestedOn = DateTimeField() | ||
| requestedBy = ForeignKeyField(User) | ||
|
|
||
| class Meta: | ||
| indexes = ( (('academicYear', 'department'), True), ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using g.openterm will create a lot of bugs in case user have two open term, if the position review is for next ay while the openterm is for this ay