Create Logic to Notify Academic Advisors of Overloads - #670
Open
ACBerea wants to merge 13 commits into
Open
Conversation
…lied template in emailhandler.py and pulled advisor email from student account as email recipient.
… future in emailHandler.py.
…Team/lsf into AC_NotifAcadAdvisOverloads
…Team/lsf into AC_NotifAcadAdvisOverloads
…isor in base_data.py and added on academic advisor element for email template use in emailHandler.py
…Team/lsf into AC_NotifAcadAdvisOverloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT
The code currently lacks access to academic advisors' emails from the Tracy database and thus cannot be completed until Labor is contacted. The only information currently in Tracy is advisor names.
Issue Description
When an overload form is approved, we should notify academic advisors.
Fixes issue #355
Changes
Testing
Follow these steps to gain email access in Slack (These are also in the README.md.):
There are a couple of options to test email handling. By default, all emails will be logged to the slack channel #labor-emails in the bereacs workspace.
If you want to test with actual emails, use an email other than outlook to test email handler. This setup is specific to gmail, but should work with any other email that allows you to make app passwords
Ensure you are on the development APP_ENV.
Reset the database using the production backup information.
Follow these steps in MySQL to add a fake overload form:
Flask run the program.
On the sidebar, open the Administration accordion and click Pending Forms
On the Pending Forms page:
Check Slack to see if you have received the email. (It will come with two other emails).
Issues with Current Code