Repository navigation
fix(segments): reject negative and non-finite durations - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boundaries_from_durationsaccepted negative, NaN and infinite durations. It built backwards or NaN ranges that only failed later inside FFmpeg. It now checks every duration and raisesValueErrornaming the offending index before any range is built.Nonestill yield an empty(t, t)range that keeps the part's slot, so later indices stay aligned. Empty input still returns[].ValueErrorwith the index instead of a bare conversion error.Plan unit: KC-1 (portfolio remediation 2026-09-29).
Test plan
TestDurationValidationintests/test_segments.py:[10, -5, 3], NaN, +inf, -inf, a non-numeric string, generator input, and monotonic output for supported input. Six of these were red before the change (DID NOT RAISE ValueError).ruff check .clean.Acceptance
test_supported_input_gives_monotonic_ranges.[10, -5, 3], NaN and infinity fail before FFmpeg: the error is raised insideboundaries_from_durations.Not in this PR