Skip to content

DELIVERY: assert the new build against an old database - #24

Open
arnelirobles wants to merge 1 commit into
mainfrom
gate/assert-against-an-old-database
Open

arnelirobles wants to merge 1 commit into
mainfrom
gate/assert-against-an-old-database

Conversation

@arnelirobles

@arnelirobles arnelirobles commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

One gate, from barakoCMS today.

A Marten upgrade needed fourteen ALTER statements on the event store. The branch carried a migration for the new dependency's own tables and stated the schema story was handled. A test asserting that the schema assert command does not throw passed, because the integration fixture builds its database from the build under test, so there was no drift for it to find. The CI job that starts from an older release went red on the same commit.

That is the third time the shape has reached a branch in that repo, after a new index and a column on an existing document table. Under AutoCreate.CreateOnly the consequence each time is a host that throws on start and crash-loops with the previous container already gone.

The four em dashes the style check reports are pre-existing, in sections this branch does not touch.

Summary by CodeRabbit

  • Documentation
    • Added guidance to validate new builds against existing databases, rather than only freshly created databases.
    • Documented how migration issues can be missed by fresh-database checks and appear when upgrading from an older release.
    • Clarified that a successful schema check confirms compatibility with a newly created database, not migration support for existing databases.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 9eafdc5c-9417-4d05-9446-8103e4728485

📥 Commits

Reviewing files that changed from the base of the PR and between b0df4b6 and 742a387.

📒 Files selected for processing (1)
  • DELIVERY.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request adds a DELIVERY.md section that requires schema checks against pre-existing databases. It documents how same-build database fixtures can miss migration drift and records a barakoCMS incident involving AutoCreate.CreateOnly.

Changes

Schema migration validation guidance

Layer / File(s) Summary
Pre-existing database schema checks
DELIVERY.md
Adds guidance that a schema check against a database created by the current build cannot detect missing migrations. Documents the barakoCMS incident and the limitation of AutoCreate.CreateOnly for existing tables.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a delivery check that validates the new build against an existing database.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant