fix(design): block validator egress and harden review key exposure - #102
Conversation
|
Warning Review limit reached
Next review available in: 43 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details鈿欙笍 Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 馃搾 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep OpenRouter out of design-review process environ (file mount + run_command procfs/secrets deny) and add validator to the egress hostname blocklist so sandboxes cannot reach co-located control-plane services.
Trim run_command path denies and drop the unused take_openrouter helper so challenge-agentic stays within the 1500 non-test LOC gate.
607ffaa to
1e9505a
Compare
Summary
validatorto Design egressBLOCKED_HOSTNAMES(defense-in-depth alongside post-DNS IP deny).OPENROUTER_API_KEYin thedesign-reviewcontainer environ; mount it asOPENROUTER_API_KEY_FILEunder/run/review-secrets(Linux/proc/<pid>/environis a boot-time snapshot and cannot be scrubbed byunsetenv).run_command: keep childenv_clear, deny procfs and review-secrets paths. Document thatAGENTIC_ENABLE_RUN_COMMAND=1stays on in prod with these mitigations.Test plan
cargo test -p design-egress-proxy -p challenge-agentic -p review-docker --libcargo clippy -p design-egress-proxy -p challenge-agentic -p review-docker -p challenge-review-bin --all-targets -- -D warningscargo run -p xtask -- design-checkOPENROUTER_API_KEY_FILE(notOPENROUTER_API_KEY=) and egress still blocksvalidatorby name