Skip to content

fix(design): isolate screenshot Chromium via egress proxy - #103

Merged
echobt merged 1 commit into
mainfrom
fix/design-screenshot-chromium-isolation
Aug 8, 2026
Merged

fix(design): isolate screenshot Chromium via egress proxy#103
echobt merged 1 commit into
mainfrom
fix/design-screenshot-chromium-isolation

Conversation

@echobt

@echobt echobt commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Force screenshot Chromium (--no-sandbox, file://) through design-egress-proxy with --proxy-bypass-list=<-loopback> so control-plane / metadata SSRF is blocked by the same post-DNS blocklist as miner sandboxes.
  • Neutralize SSRF-ish href/src (gateway, socket-proxy, postgres, RFC1918, metadata) in ammonia sanitize; capture documents get nonce-locked CSP + navigate-to 'none' (CLI Chromium has no Playwright route hooks).
  • Compose sets DESIGN_SCREENSHOT_PROXY; assert-compose-matrix confirms staging/prod keep host Sim fail-closed and force the proxy. Produced HTML remains unserved.

Test plan

  • cargo test -p design-sanitize -p design-challenge --lib
  • cargo clippy -p design-sanitize -p design-challenge --all-targets -- -D warnings
  • ./deploy/scripts/assert-compose-matrix.sh
  • cargo run -p xtask -- design-check
  • Staging deploy recreates design-challenge with DESIGN_SCREENSHOT_PROXY=http://design-egress-proxy:8094
  • Spot-check a new design run still gets index.png

Force --no-sandbox file:// captures through design-egress-proxy (incl.
loopback), neutralize SSRF-ish href/src in sanitize, and keep host Sim
fail-closed on staging/prod.
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@echobt, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
鈿欙笍 Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 60427ed5-f9b9-4f18-8530-9c98d950e68e

馃摜 Commits

Reviewing files that changed from the base of the PR and between 1e688ad and 9ffdff9.

馃搾 Files selected for processing (7)
  • crates/design-challenge/src/screenshot.rs
  • crates/design-sanitize/src/lib.rs
  • deploy/scripts/assert-compose-matrix.sh
  • docker-compose.yml
  • docs/DESIGN_CHALLENGE.md
  • docs/OPERATOR_SECURITY.md
  • docs/THREAT_MODEL.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

鉂わ笍 Share

Comment @coderabbitai help to get the list of available commands.

@echobt
echobt merged commit 50addb1 into main Aug 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant