fix(design): isolate screenshot Chromium via egress proxy - #103
Conversation
Force --no-sandbox file:// captures through design-egress-proxy (incl. loopback), neutralize SSRF-ish href/src in sanitize, and keep host Sim fail-closed on staging/prod.
|
Warning Review limit reached
Next review available in: 50 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details鈿欙笍 Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 馃搾 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
--no-sandbox,file://) throughdesign-egress-proxywith--proxy-bypass-list=<-loopback>so control-plane / metadata SSRF is blocked by the same post-DNS blocklist as miner sandboxes.href/src(gateway, socket-proxy, postgres, RFC1918, metadata) in ammonia sanitize; capture documents get nonce-locked CSP +navigate-to 'none'(CLI Chromium has no Playwright route hooks).DESIGN_SCREENSHOT_PROXY;assert-compose-matrixconfirms staging/prod keep host Sim fail-closed and force the proxy. Produced HTML remains unserved.Test plan
cargo test -p design-sanitize -p design-challenge --libcargo clippy -p design-sanitize -p design-challenge --all-targets -- -D warnings./deploy/scripts/assert-compose-matrix.shcargo run -p xtask -- design-checkdesign-challengewithDESIGN_SCREENSHOT_PROXY=http://design-egress-proxy:8094index.png