feat(genre-tree)!: page genre playlist tracks lazily - #133
Merged
Merged
Conversation
Play fetches {me/}genre-playlists/{uuid}/tracks/ page by page instead of
the playlist detail; the track list auto-loads near the end and the
sidebar infinite-scrolls.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Genre-playlist play no longer downloads the full playlist detail (thousands of tracks with nested
playlists). It pagesGET {me/}genre-playlists/{uuid}/tracks/(100 per page, served by grow API v8.2.0 / hear API v5.2.0) and loads more lazily. Breaking → app-kit 8.0.0.Changes
TrackListProviderfetches pages itself with itsschema;playNewTrackListFromGenrePlaylist(genrePlaylist, scope)is async and ignores superseded requests (including their failures).loadMore()onuseTrackList(): in-flight guard, dedupe, and it ignores stale-origin and stale-closure pages. The provider auto-loads when the selected track is within 10 tracks of the end.TrackListgainstotal/nextPage.TrackListSidebarshows the total and infinite-scrolls using an IntersectionObserver sentinel.TrackBase.playlists,trackPlaylistRelationsfromCriteriaPlaylistDetailedSchema,makeCriteriaPlaylistDetailedSchema,CriteriaPlaylistDetailedLike,useFetchGenrePlaylistDetailed, andGenreTreeView'scriteriaPlaylistDetailedSchemaprop.genrePlaylistEndpoints.tracks(uuid)andmakeTrackPlaylistRelPageSchema.Test plan
pnpm lint && pnpm build && pnpm test(586 tests, coverage thresholds met)criteriaPlaylistDetailedSchemaprop after the 8.0.0 release.🤖 Generated with Claude Code