Repository navigation
fix(genre-tree): align album and criteria update schemas with the API - #136
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlbumMinimumSchema.album_artists→albumArtists. Both the grow and hear APIs render camelCase, so zod silently dropped the field on every track.CriteriaUpdateSchema.parentandupdateGenreParent(uuid, parentUuid)now acceptnull, matching grow'scriteria/input/put.py. A genre can be made a root again.Found while checking grow-the-music-tree-frontend's contract against grow API v8.3.3.
Test plan
CriteriaUpdateSchematest:{ parent: null }parses.pnpm lint && pnpm build. The vitest run had 3 timeouts under machine load (GenreTreeView, Rating, AuthPopup); they pass when rerun in isolation.🤖 Generated with Claude Code