Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/skills/code-review/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Any user-facing change (new export, behavior change, bug fix) needs a
## Publishing (blocking)

Flag any direct use of `npm publish`. Releases must go through
`pnpm release -- <bump>` (`scripts/release.sh`).
`pnpm release <bump>` (`scripts/release.sh`).

## General

Expand Down
4 changes: 2 additions & 2 deletions CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ to be" framing. History belongs in git log and `CHANGELOG.md`, not in reference
- `develop` — GitHub default branch, integration branch for all in-progress work. Branch
`feature/*` from here for all non-release, non-hotfix work (features, fixes, chores); PR back
into here. No other prefixes (`fix/*`, `chore/*`, …).
- `release/*` — cut from `develop` by `pnpm release -- <bump>` (`scripts/release.sh`), which also
- `release/*` — cut from `develop` by `pnpm release <bump>` (`scripts/release.sh`), which also
pushes it and opens PRs into both `main` and `develop`. After the `main` PR merges, run
`pnpm tag-release` on `main` to tag and trigger the publish workflow.
- `hotfix/*` — cut from `main` for urgent production fixes; PR'd into both `main` and `develop`,
Expand All @@ -72,7 +72,7 @@ to be" framing. History belongs in git log and `CHANGELOG.md`, not in reference
(see Branching above)
- Merging or pushing directly to `main` or `develop`, including from `release/*`/`hotfix/*` —
always go through a PR, even with branch-protection bypass rights
- Publishing directly with `npm publish` — always go through `pnpm release -- <bump>`
- Publishing directly with `npm publish` — always go through `pnpm release <bump>`
(`scripts/release.sh`) followed by `pnpm tag-release`, which also updates the changelog and
lockfile

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ the change being clearly described.
From a clean, up-to-date `develop`:

```bash
pnpm release -- patch # or minor / major
pnpm release patch # or minor / major
```

This creates a `release/X.Y.Z` branch off `develop`, bumps `packages/app-kit/package.json`'s
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ branch for PRs. See [CONTRIBUTING.md](CONTRIBUTING.md) for the full model.
_(For maintainers, run from a clean, up-to-date `develop`)_

```bash
pnpm release -- patch # or minor / major
pnpm release patch # or minor / major
```

Cuts a `release/X.Y.Z` branch off `develop`, bumps the package version, moves `CHANGELOG.md`'s
Expand Down
2 changes: 1 addition & 1 deletion architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ the one known gap (a CJS consumer mixing subpath imports of the same shared cont
- Build: `tsup` — one entry per module (`src/<module>/index.ts`) plus the root barrel, emitting
ESM + CJS + `.d.ts` per entry into `dist/`.
- Registry: GitHub Packages (`https://npm.pkg.github.com`, scope `@behindthemusictree`).
- Release pipeline: `scripts/release.sh` (invoked as `pnpm release -- <bump>`) → git tag →
- Release pipeline: `scripts/release.sh` (invoked as `pnpm release <bump>`) → git tag →
`.github/workflows/publish.yml` builds and publishes on tag push. Never `npm publish` directly.
- Branching model: strict Gitflow — see `CONTRIBUTING.md` § Branching (Gitflow) and the
"Branching" section of `CLAUDE.md`.
2 changes: 1 addition & 1 deletion scripts/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -euo pipefail
BUMP="${1:-}"

if [[ -z "$BUMP" ]]; then
echo "Usage: pnpm run release -- <patch|minor|major>"
echo "Usage: pnpm release <patch|minor|major>"
exit 1
fi

Expand Down
Loading