Release the jinni as a repo-unit package - #5
Merged
Merged
Conversation
…ease b3-builder's Action releases by walking the immediate subdirs of the source dir for a manifest.json, and only the repo unit finalizes each atom's download URL. Staged flat with unit: plugin, the jinni packed and signed, released nothing, and the run then failed with no release to attach the index atom to. The staging script now composes dist/package/<name>/, and both workflows pass unit: repo, so a pull request proves the same shape a tag releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jinni release tag built and signed a .b3 and then cut no release at all: b3-builder's Action releases by walking the immediate subdirs of the source dir for a manifest.json, and the package was staged flat. Only the repo unit finalizes each atom's download URL, so the plugin unit could not have registered a usable index entry either.
The staging script now composes
dist/package/<name>/, both workflows passunit: repo, and a test asserts the named dir because that is what releases.