fix: resolve temporary new-thread IDs before deletion - #1740
Open
Rat0323 wants to merge 2 commits into
Open
Conversation
Rat0323
marked this pull request as ready for review
August 1, 2026 19:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local:client-new-thread:*to the persisted conversation UUID before deletionRoot cause
Codex initially renders a new sidebar conversation with a client-only placeholder ID such as
local:client-new-thread:*. The persisted thread already exists under its UUID, but Codex++ preferred the placeholder DOM attribute and sent it to the delete endpoint. Local storage correctly returnedThread not found in local storage. Restarting rebuilt the sidebar with the canonical UUID, which is why deletion then succeeded.Validation
cargo fmt --all -- --checkcargo test -p codex-plus-core --test cdp_bridge(95 passed)npm test --prefix apps/codex-plus-manager(36 passed)git diff --checkIntegration note
This is intentionally independent from #1737. If #1737 lands first, this PR may need a small rebase around the delete event delegation block. The known cross-platform line-ending CI fix remains tracked separately in #1735.