Fix Codex++ menu anchoring on current Codex top bar - #1743
Open
Rat0323 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ApplicationMenuTopBarused by Codex 26.727.6591.0..app-header-tintas a legacy compatibility selector.headerfallback that incorrectly attached the menu to conversation content.Why
The latest Codex removed the old
.app-header-tintnode. Falling back to the conversationheadermoved the Codex++ UI down and made it drift when side conversations or split layouts changed.Validation
node --check assets/inject/renderer-inject.jsnpm --prefix apps/codex-plus-manager test -- --test-name-pattern="renderer injection header compatibility"(37 passed)git diff --check