fix: keep repeated launcher on existing bridge - #1776
Open
k9ight000 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Launching CodexPlusPlus a second time can acquire the existing-instance path, start a temporary helper, reinject the page, and then exit. The page is left pointing at the temporary helper, so conversation delete requests fail even though the delete controls remain visible.
Fix
Validation
cargo fmt --check --package codex-plus-launchercargo test -p codex-plus-launcher --no-runcargo test -p codex-plus-core --test launcher -j 1 -- --skip app_paths_resolves_portable_current_link_to_directory_version— 74 passedThe skipped test requires Windows symbolic-link privilege and is unrelated to this change. The published diff contains only
apps/codex-plus-launcher/src/main.rsand was scanned for credentials and local user paths.