Skip to content

ePlant world eFP fixes (part of yukthiw/world-efp-v2 PR #175) #183

Description

@VinLau

List of bugs/optimizations to be fixed before full merge into staging:

  • Standard error is incorrect:

Check https://bar.utoronto.ca/api_dev/microarray_gene_expression/world_efp/arabidopsis/AT3G24650:

Values are:
"values": {
"ATGE_111_A": 13.7,
"ATGE_111_B": 28.15,
"ATGE_111_C": 19.65
},
Hence the Mean is 20.5, and the STD Dev is 5.92 (population; sample is 7.3), right now:

Image
  • Many markers are disproportionately red:

Likely a bygone of the experimental/tissue eFPs - tissues (in this case ecotypes) are normalized to the ENTIRE experiment (i.e. entire map) not a subgroup:

Image

Expected behaviour: Yellow-orange hue for this marker

  • Relative mode recolours markers in absolute yellow-red scale

For ABI3 on USA markers:

Image Image

Expected behaviour: Yellow Green Blue Scale with yellow-green-blue markers

  • World eFP link stores map overlay but does not load it

Honestly optional fix given ePlant2 doesn't store the overlay state (URL is https://bar.utoronto.ca/eplant/?ActiveSpecies=Arabidopsis%20thaliana&Genes=AT3G24650&ActiveGene=AT3G24650&ActiveView=WorldView):

/world-efp/AT3G24650?position.lat=45.4444294479948&position.lng=-85.09814027956283&zoom=4&mapTypeId=satellite&maskModalVisible=false&maskingEnabled=false&maskThreshold=100&colorMode=absolute&overlay=None

We can see satellite is stored in params URL but when you enter this URL you get default roadmap.

Expected: load whatever mapTypeId is specified (optional though IMO)

  • Similar to above, masking threshold in URL does not apply:

world-efp/AT3G24650?position.lat=25&position.lng=0&zoom=4&mapTypeId=roadmap&maskModalVisible=false&maskingEnabled=true&maskThreshold=150&colorMode=absolute&overlay=None

Everything will reset to default on this URL, i.e. no masking applies - this works in experimental eFP so we just need to apply the logic here too!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions