Skip to content

feat(statics): add SoFiUSD and USD1 token definitions on Tempo, Monad… - #9390

Open
zeeshanamjad-eng wants to merge 1 commit into
masterfrom
SCAAS-10692/onboard-sofid-usd1-multi-chain
Open

feat(statics): add SoFiUSD and USD1 token definitions on Tempo, Monad…#9390
zeeshanamjad-eng wants to merge 1 commit into
masterfrom
SCAAS-10692/onboard-sofid-usd1-multi-chain

Conversation

@zeeshanamjad-eng

@zeeshanamjad-eng zeeshanamjad-eng commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

…, Polygon, GasEVM

Also fixes hteth:wbtc contract address to 0x219d33e6fcd0c8cdbc12b10205592f286d458a33.

Ticket: SCAAS-10692

@linear-code

linear-code Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

SCAAS-10692

@zeeshanamjad-eng
zeeshanamjad-eng requested a review from Copilot July 30, 2026 10:06
@zeeshanamjad-eng

Copy link
Copy Markdown
Contributor Author

@claude

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Claude finished @zeeshanamjad-eng's task —— View job


Code Review Progress

  • Read repository guidelines (CLAUDE.md)
  • Review token definition changes across all modified files
  • Check consistency between different network implementations
  • Verify adherence to existing patterns and conventions
  • Provide comprehensive review feedback

Code Review Summary

I've completed a thorough review of the PR that adds SoFiUSD and USD1 token definitions across multiple blockchain networks. Here are my findings:

Positive Aspects

  1. Consistent Pattern Following: The implementation correctly follows established patterns for token definitions across all networks
  2. Proper Network Coverage: Comprehensive coverage across mainnet and testnet for all supported networks
  3. Correct Token Features: Appropriate use of CoinFeature.STABLECOIN for both SoFiUSD and USD1
  4. Complete Implementation: All necessary files are updated (base enums, network-specific configs, OFC variants)

📋 Detailed Analysis by Network

SoFiUSD Token (6 decimals):

  • Tempo: Added to both mainnet (tempo:sofid) and testnet (ttempo:sofid, ttempo:stgsofid)
  • Monad: Added to both mainnet (mon:sofid) and testnet (tmon:sofid, tmon:stgsofid)
  • Polygon: Added to both mainnet (polygon:sofid) and testnet (tpolygon:sofid, tpolygon:stgsofid)

USD1 Token (18 decimals):

  • GasEVM: Added to both mainnet (gasevm:usd1) and testnet (tgasevm:usd1, tgasevm:stgusd1)

🔍 Technical Verification

  1. Unique IDs: All token entries use proper UUID v4 format
  2. Contract Addresses: All Ethereum addresses follow proper format (0x + 40 hex chars)
  3. Decimals: Consistent across networks (SoFiUSD: 6, USD1: 18)
  4. UnderlyingAsset Enum: All new assets properly added to base.ts:3210-4535
  5. Feature Flags: Appropriate features applied (STABLECOIN, EVM_NON_BITGO_RECOVERY, etc.)

🏗️ Architecture Compliance

  • OFC Support: Both tokens properly added to OFC (Off-Chain) variants
  • Test Coverage: Both mainnet and testnet configurations included
  • Staging Variants: Appropriate staging token variants (stg*) included for testnet

⚠️ Minor Observations

  1. Contract Address Reuse: I notice some contract addresses appear to be reused between networks (e.g., SoFiUSD uses same address 0xa7171032d2f41828dffd793149823e13f79c456e on both tmon and tpolygon testnets). This is likely intentional for testing but worth confirming.

  2. Network Consistency: The implementation correctly handles the different network architectures (EVM-compatible chains vs. Tempo's TIP-20 standard).

🎯 Recommendation

✅ APPROVED - This PR is well-implemented and follows all established patterns. The token definitions are complete, consistent, and properly structured across all target networks. No blocking issues identified.

The changes are ready for merge assuming the contract addresses are correct for each respective network.


Job Run | Branch: SCAAS-10692/onboard-sofid-usd1-multi-chain

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new token metadata to @bitgo/statics for SoFiUSD and USD1 across several supported networks (Polygon, Tempo, Monad, and GasEVM / Neo X), ensuring the assets are available via the statics coin/token registries and OFC mappings.

Changes:

  • Added SoFiUSD token definitions for Polygon (mainnet + testnet), Tempo (mainnet + testnet), and Monad (mainnet + testnet).
  • Added USD1 token definitions for GasEVM (mainnet + testnet), including OFC ERC20 metadata.
  • Extended UnderlyingAsset to include the new asset identifiers required by the new token entries.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
modules/statics/src/coins/polygonTokens.ts Adds Polygon SoFiUSD entries (mainnet + testnet variants).
modules/statics/src/coins/ofcErc20Coins.ts Adds OFC ERC20 entries for Monad SoFiUSD and GasEVM USD1.
modules/statics/src/coins/ofcCoins.ts Adds OFC coin/token entries for Polygon and Tempo SoFiUSD (mainnet + testnet variants).
modules/statics/src/base.ts Adds UnderlyingAsset enum values for SoFiUSD and USD1 across the relevant networks.
modules/statics/src/allCoinsAndTokens.ts Registers GasEVM USD1 (mainnet/testnet), Tempo SoFiUSD (mainnet/testnet), and Monad SoFiUSD (mainnet/testnet).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/statics/src/coins/polygonTokens.ts
@zeeshanamjad-eng
zeeshanamjad-eng force-pushed the SCAAS-10692/onboard-sofid-usd1-multi-chain branch from 84a4166 to 94b4d8c Compare July 30, 2026 10:48
'mon:sofid',
'SoFiUSD',
6,
'0x5572728e36b5510010ade1db6bbaea1c402411cc',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we deployed the prod token ?,

The current prod explore is showing nothing

https://monadscan.com/token/0x5572728e36b5510010ade1db6bbaea1c402411cc#transactions

Can you check is this the correct prod contract

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not deployed, but the address is going to be the same, @sachushaji will deploy it

Comment thread modules/statics/src/allCoinsAndTokens.ts Outdated
Comment thread modules/statics/src/allCoinsAndTokens.ts Outdated
Comment thread modules/statics/src/allCoinsAndTokens.ts
@zeeshanamjad-eng
zeeshanamjad-eng force-pushed the SCAAS-10692/onboard-sofid-usd1-multi-chain branch from 94b4d8c to bd01cf3 Compare July 30, 2026 11:16
@zeeshanamjad-eng
zeeshanamjad-eng marked this pull request as ready for review July 30, 2026 11:19
@zeeshanamjad-eng
zeeshanamjad-eng requested a review from a team as a code owner July 30, 2026 11:19
@zeeshanamjad-eng
zeeshanamjad-eng force-pushed the SCAAS-10692/onboard-sofid-usd1-multi-chain branch from bd01cf3 to 2f887b1 Compare July 30, 2026 11:27
…, Polygon, GasEVM

Also fixes hteth:wbtc contract address to 0x219d33e6fcd0c8cdbc12b10205592f286d458a33.

Ticket: SCAAS-10692
Co-authored-by: Cursor <cursoragent@cursor.com>
@zeeshanamjad-eng
zeeshanamjad-eng force-pushed the SCAAS-10692/onboard-sofid-usd1-multi-chain branch from 2f887b1 to 703b81d Compare July 30, 2026 11:33
undefined,
undefined,
true,
'gasevm'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check this part with @nvrakesh06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants