fix(statics): keep Singapore excluded from RBTC custody - #9391
Open
claude[bot] wants to merge 1 commit into
Open
fix(statics): keep Singapore excluded from RBTC custody#9391claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
RBTC_FEATURES explicitly listed CUSTODY_BITGO_SINGAPORE, but that was already a no-op: ETH_FEATURES (spread into RBTC_FEATURES) pulls in CUSTODY_BITGO_SINGAPORE via ACCOUNT_COIN_DEFAULT_FEATURES, so simply deleting the explicit entry would not have removed it from the resulting feature list. Filter CUSTODY_BITGO_SINGAPORE out of the final RBTC_FEATURES array instead, matching the exclusion pattern already used elsewhere in this file (e.g. CELO_FEATURES, ETH_FEATURES_WITH_FRANKFURT_EXCLUDE_SINGAPORE). Per COIN-5477 and team decision in Slack, Singapore trusts should stay gated out of RBTC custody once RBTC custody wallets are enabled (BitGo/bitgo-microservices#61593). TICKET: CECHO-1849
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<!-- ccr-slack-attribution -->
Requested by Shubham Damkondwar, Kushagra Sharma · Slack thread
Description
Companion PR: BitGo/bitgo-microservices#61593 (CECHO-1849) enables RBTC custody wallets at the wallet-platform method level. Once that PR merges, any
CoinFeaturecurrently attached toRBTC_FEATURESwould become eligible for RBTC custody, including Singapore.Per the decision in the linked Slack thread ("yes we can keep it gated for singapore") and the precedent set in the old ticket COIN-5477 (gating RBTC for Singapore), Singapore trusts should remain excluded from RBTC custody. This PR makes that gating actually effective in
@bitgo/statics.Before
RBTC_FEATURESexplicitly listedCoinFeature.CUSTODY_BITGO_SINGAPORE:Simply deleting that line would not have achieved the goal:
ETH_FEATURESspreadsACCOUNT_COIN_DEFAULT_FEATURES, which already includesCoinFeature.CUSTODY_BITGO_SINGAPOREby default. SinceRBTC_FEATURESspreadsETH_FEATURES, the explicit entry was actually redundant with an inherited default — removing only that line would have been a no-op, and Singapore would still end up in the finalRBTC_FEATURESarray (and therefore still gain RBTC custody access once the companion PR ships).After
RBTC_FEATURESnow explicitly filtersCUSTODY_BITGO_SINGAPOREout of the final array, the same exclusion pattern already used elsewhere in this file for coins that need to remove a feature inherited via a spread (e.g.CELO_FEATURES,ETH_FEATURES_WITH_FRANKFURT_EXCLUDE_SINGAPORE,TEMPO_FEATURES_EXCLUDE_SINGAPORE):This guarantees
CoinFeature.CUSTODY_BITGO_SINGAPOREcannot end up onrbtc/trbtcregardless of whatETH_FEATURES/ACCOUNT_COIN_DEFAULT_FEATURESinclude in the future.How this pairs with the companion PR
Type of change
How Has This Been Tested?
CUSTODY_BITGO_SINGAPOREis inherited intoETH_FEATURESviaACCOUNT_COIN_DEFAULT_FEATURES, so a plain line removal would have been a no-op.modules/statics/src/coinFeatures.tsin isolation (tsc --noEmit) — no errors.RBTC_FEATURESis consumed directly by therbtcaccount definition and viaAccountCoin.getFeaturesByTypeExcludingfortrbtcinmodules/statics/src/allCoinsAndTokens.ts, so this fix covers both.Ticket: CECHO-1849
Generated by Claude Code