Distinguish duplicate uploads from other 409 conflicts - #456
Merged
dylanuys merged 1 commit intoSep 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #450. Only the upload API's explicit
409 File with this hash already existsresponse is treated as an already-uploaded file.Registration, pending/expired reservation, burn-credit mismatch, and unknown conflicts now return the actual error instead of falsely allowing the CLI to continue. Saved receipts are retained, and these conflicts do not trigger another burn. Existing consumed-credit retry behavior is unchanged.
Tests
104 tests and CI-selected Ruff checks passed. Added regressions for initial presign responses and saved-receipt retries, including legitimate duplicates and unrelated 409s.