Skip to content

Fix generator rewards truncated by global 1,000-outcome cap - #462

Merged
dylanuys merged 3 commits into
testnetfrom
fix/full-window-generator-rewards
Sep 19, 2026
Merged

dylanuys merged 3 commits into
testnetfrom
fix/full-window-generator-rewards

Conversation

@dylanuys

@dylanuys dylanuys commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the implicit global 1,000-outcome cap from generator reward statistics so all eligible outcomes in the validator's 24-hour window contribute.
  • Keep explicit limits available for diagnostic callers; preserve completion-time filtering, per-modality pass rates, and exclusion of no_answer outcomes.
  • Bump both version strings to 5.0.8 for validator auto-updates; keep 5.0.8 when merging the updated testnet branch.

The cap could crowd out a miner's verified images with newer outcomes from other miners. In the investigated snapshot, 3,120 eligible outcomes were reduced to roughly seven hours of history, dropping two verified images still inside the intended 24-hour window.

Validation

  • SQLite regressions cover more than 1,000 newer outcomes, older qualified image rewards, the exact time cutoff, excluded states/no-answers, and explicit limits through the reward-facing wrapper.
  • Combined testnet suite: 212 passed. CI-selected Ruff checks, lockfile consistency, and git diff --check passed. Callback startup and signed-upload/retry smoke tests passed with the pinned security dependencies.

@dylanuys
dylanuys merged commit a3cfc77 into testnet Sep 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant