Skip to content

feat(glaziery): ancient runic glass stained chandelier, iron armature assembly, and cathedral radiance engine - #285

Open
angelTomo9 wants to merge 2 commits into
Bitcoindefi:mainfrom
angelTomo9:feat-stained-chandelier-1788150065042
Open

feat(glaziery): ancient runic glass stained chandelier, iron armature assembly, and cathedral radiance engine#285
angelTomo9 wants to merge 2 commits into
Bitcoindefi:mainfrom
angelTomo9:feat-stained-chandelier-1788150065042

Conversation

@angelTomo9

Copy link
Copy Markdown

Summary

Implements an ancient runic glass stained chandelier, wrought iron armature assembly, and cathedral radiance lighting system, chandelier assembly hoists (Cedar Chandelier Assembly Hoist, Runic Wrought Iron Armature Bench, Celestial Void Cathedral Corona Sanctum), raw blown glass cupolas (Cathedral Amber Glass Cupola, Faceted Lead Crystal Pendant, Celestial Void Starfire Corona Glass), sacred chandelier recipes (Sanctuary Vesper Chandelier, High Altar Iron Corona Chandelier, Celestial Void Seraphic Cathedral Chandelier), illuminance radiance ratings (scaled across catalog baselines ~14% to 100%), calibrated holy aura radius and mana recharge aura scaling, upfront material deduction on all attempts, consistent remainingProvidedCupolas shapes across all branches, and chandelier hoist maintenance for OpenAO MMORPG.

Features

  • Chandelier hoist catalog with power ratings, durability, and radiance bonuses
  • Sacred chandelier recipes with calibrated holy aura radius and mana recharge aura scaling
  • Independent illuminance radiance quality roll scaling
  • Upfront material deduction on all craft attempts to prevent zero-cost retries
  • Consistent remainingProvidedCupolas arrays returned on all early rejection branches
  • Cached static catalog maxima and table maintenance with durability threshold gating
  • Full unit test coverage under Vitest including mid-range radiance tests

…ture assembly, and cathedral radiance engine
Comment thread api/src/tests/ancientRunicGlassStainedChandelier.test.ts Outdated
@gitar-bot

gitar-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Adds chandelier assembly hoists, raw blown glass cupolas, and sacred chandelier recipes with calibrated holy aura radius, mana recharge scaling, and illuminance radiance ratings for the OpenAO MMORPG. Includes full unit test coverage and upfront material deduction to prevent zero-cost retries. Test import convention issue resolved.

✅ 1 resolved
Bug: Test import uses .js extension against project convention

📄 api/src/tests/ancientRunicGlassStainedChandelier.test.ts:5
The new test imports the source module as ../lib/ancientRunicGlassStainedChandelier.js, but the actual file is .ts and every other test in api/src/tests imports local modules extensionless (e.g. ../repositories/worldBuilder). The api package has no "type": "module" set, so this diverges from the established resolution convention and may fail to resolve under the Vitest/Vite resolver, preventing the test file from running. Drop the .js extension to match the rest of the suite.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant