feat(leathercraft): ancient runic leather tack saddle bench, stirrup rigging, and mount engine - #290
Open
angelTomo9 wants to merge 1 commit into
Open
Conversation
…rup rigging, and mount engine
Code Review ✅ ApprovedImplements a comprehensive ancient runic leather tack saddle bench, stirrup rigging, and mount engine system for OpenAO MMORPG, including saddle bench catalog with power ratings and durability, mount saddle recipes with calibrated stamina conservation and impact mitigation, upfront material deduction to prevent zero-cost retries, and full unit test coverage. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 1 day — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an ancient runic leather tack saddle bench, stirrup rigging, and mount harness crafting system, saddle benches (Oak Saddle Stitching Horse, Runic Ironwood Harness Bench, Celestial Void Seraphic Mount Sanctum), raw tanned bridle leather and forged steel stirrups (Tanned Cowhide Harness Strap, Tempered Steel Stirrup Ring, Celestial Void Starlight Barding Leather), mount saddle recipes (Courier Swift-Gallop Saddle, Knight Armored Warhorse Barding, Celestial Void Seraphic Pegasi Saddle), mount comfort ratings (scaled across catalog baselines ~14% to 100%), calibrated mount stamina conservation and rider impact mitigation scaling, upfront material deduction on all attempts, consistent remainingProvidedLeathers shapes across all branches, extensionless test import, crypto-secure default gameplay rolls strictly in [0, 1), and saddle bench maintenance for OpenAO MMORPG.
Features