Repository navigation
Bound camera metadata helper output - #47
Merged
Merged
Conversation
mikecerisano
force-pushed
the
fix/metadata-subprocess-output-20261017
branch
from
October 17, 2026 15:16
1704d87 to
463c31e
Compare
mikecerisano
force-pushed
the
fix/metadata-subprocess-output-20261017
branch
from
October 17, 2026 16:00
463c31e to
d012214
Compare
mikecerisano
marked this pull request as ready for review
October 17, 2026 16:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A camera metadata helper could block when
mdlsorffprobefilled stdout: BitMatch waited for the process to exit before reading its pipe. The eventualreadDataToEndOfFilealso had no memory bound. This drains output while the helper runs, caps it at 256 KiB, and discards oversized output entirely so a truncated prefix is never treated as camera metadata. Cancellation still stops the child, and existing exit-status handling stays intact. This is advisory camera detection; it does not change transfer or verification verdicts.Local validation on the final code patch:
./test.sh mac-test: passed; xcresult reports 1,201 passed, 14 skipped, 0 failed../test.sh ipad-build: passed.9cb218ba) produced an identical source/test diff (cmp) and a cleangit diff --check.Existing limitation: a helper that hangs without task cancellation and without filling stdout still has no overall timeout. This PR bounds captured output and cancellation, not that separate policy.