Repository navigation
Keep transfer safety claims tied to saved evidence - #49
Merged
Merged
Conversation
mikecerisano
force-pushed
the
audit/verification-claims-followup-20261017
branch
from
October 17, 2026 16:06
4c07431 to
9dd447d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An older History entry can have verified-looking rows without a saved selected-file plan. BitMatch could then show a green whole-card verdict in one place and an uncertain result elsewhere. A new transfer could also continue into automatic reporting after its plan write failed, because the authoritative-results callback error was caught as if it were a recoverable project-finalizer error. The app could announce success before its final journal result was saved.
This PR requires a complete saved plan for whole-card safety claims in History, PDF, JSON/CSV, Finish, queue review, recent-result surfaces, Dock, and prior-backup hints. It keeps the original saved summary and file rows visible as provenance while labeling uncertain coverage plainly. New attempts fail closed if the plan is missing or does not match authoritative per-destination rows, and direct retries clear the previous attempt's plan. Automatic MHL, project finalization, and reports stop on that plan error. Live completion and notifications wait for the settled journal result. Reopening a saved transfer now gives the Dock the reviewed record's verdict.
A project card and report can contain independently saved verification evidence before the final History write. If that later write fails, this PR does not erase those artifacts; it keeps the live outcome in attention state, suppresses a safe notification/eject signal, and tells the operator that transfer results could not be saved. Cross-store finalization remains non-atomic.
Local validation
main: Mac suite 1,214 passed, 14 skipped, 0 failed; iPad simulator build succeeded; iPad suite 65 passed, 9 skipped, 0 failed.git diff --checkclean. No SFTP or camera-metadata files changed in this PR.